The latest updates on your projects. Learn more about Vercel for Git ↗︎

This code here works:

and this code here crashes:

..same as if I would just not call hasNativeState at all, this also crashes:

So what makes it work? The assert(..) can't be hit, can it? It would crash the app...

Okay some more insights:

1. This code here crashes:

   auto nativeState = object.getNativeState(runtime);

2. This code here also crashes:

   object.hasNativeState(runtime);
   auto nativeState = object.getNativeState(runtime);

3. This code here WORKS, but it doesn't assert/crash the app???:

   if (!object.hasNativeState(runtime)) {
     assert(false);
   }
   auto nativeState = object.getNativeState(runtime);

4. This code here WORKS:

   if (!object.hasNativeState(runtime)) {
      value.toString(runtime);
   }
   auto nativeState = object.getNativeState(runtime);

So maybe the object is somehow flattened or lazy evaluated in a sense that NativeState isn't properly available?

I am still kinda baffled that the assert does not crash the app, maybe object.hasNativeState(...) is not the same as the internal assert of object.getNativeState(...)?

cc @hannojg @tmikov

Created an issue in the Hermes repo for now: facebook/hermes#1564

I think this can be fixed by just adjusting the code in the example app. No need to slow down all function calls for users by leaving this check in release builds